Class: Homebrew::FormulaAuditor Private

Inherits:
Object
  • Object
show all
Includes:
FormulaCellarChecks, Utils::Curl, Utils::Output::Mixin
Defined in:
formula_auditor.rb

Overview

This class is part of a private API. This class may only be used in the Homebrew/brew repository. Third parties should avoid using this class if possible, as it may be removed or changed without warning.

Auditor for checking common violations in Formulae.

Constant Summary collapse

PERMITTED_LICENSE_MISMATCHES =

This constant is part of a private API. This constant may only be used in the Homebrew/brew repository. Third parties should avoid using this constant if possible, as it may be removed or changed without warning.

T.let({
  "AGPL-3.0" => ["AGPL-3.0-only", "AGPL-3.0-or-later"],
  "GPL-2.0"  => ["GPL-2.0-only",  "GPL-2.0-or-later"],
  "GPL-3.0"  => ["GPL-3.0-only",  "GPL-3.0-or-later"],
  "LGPL-2.1" => ["LGPL-2.1-only", "LGPL-2.1-or-later"],
  "LGPL-3.0" => ["LGPL-3.0-only", "LGPL-3.0-or-later"],
}.freeze, T::Hash[String, T::Array[String]])
INCOMPATIBLE_LICENSES =

This constant is part of a private API. This constant may only be used in the Homebrew/brew repository. Third parties should avoid using this constant if possible, as it may be removed or changed without warning.

The following licenses are non-free/open based on multiple sources (e.g. Debian, Fedora, FSF, OSI, ...)

T.let([
  "Aladdin",    # https://www.gnu.org/licenses/license-list.html#Aladdin
  "CPOL-1.02",  # https://www.gnu.org/licenses/license-list.html#cpol
  "gSOAP-1.3b", # https://salsa.debian.org/ellert/gsoap/-/blob/HEAD/debian/copyright
  "JSON",       # https://wiki.debian.org/DFSGLicenses#JSON_evil_license
  "MS-LPL",     # https://github.com/spdx/license-list-XML/issues/1432#issuecomment-1077680709
  "OPL-1.0",    # https://wiki.debian.org/DFSGLicenses#Open_Publication_License_.28OPL.29_v1.0
].freeze, T::Array[String])
INCOMPATIBLE_LICENSE_PREFIXES =

This constant is part of a private API. This constant may only be used in the Homebrew/brew repository. Third parties should avoid using this constant if possible, as it may be removed or changed without warning.

T.let([
  "BUSL",     # https://spdx.org/licenses/BUSL-1.1.html#notes
  "CC-BY-NC", # https://people.debian.org/~bap/dfsg-faq.html#no_commercial
  "Elastic",  # https://www.elastic.co/licensing/elastic-license#Limitations
  "SSPL",     # https://fedoraproject.org/wiki/Licensing/SSPL#License_Notes
].freeze, T::Array[String])

Constants included from FormulaCellarChecks

FormulaCellarChecks::VALID_LIBRARY_EXTENSIONS

Constants included from OS::Mac::FormulaCellarChecks

OS::Mac::FormulaCellarChecks::MACOS_LIB_EXTENSIONS

Instance Attribute Summary collapse

Class Method Summary collapse

Instance Method Summary collapse

Methods included from Utils::Output::Mixin

#odebug, #odeprecated, #odie, #odisabled, #ofail, #oh1, #oh1_title, #ohai, #ohai_title, #onoe, #opoo, #opoo_outside_github_actions, #pretty_deprecated, #pretty_disabled, #pretty_duration, #pretty_installed, #pretty_outdated, #pretty_uninstalled

Methods included from Utils::Curl

clear_path_cache, curl, curl_args, curl_check_http_content, curl_download, curl_executable, curl_headers, curl_http_content_headers_and_checksum, curl_output, curl_path, curl_response_follow_redirections, curl_response_last_location, curl_supports_fail_with_body?, curl_supports_tls13?, curl_version, curl_with_workarounds, http_status_ok?, parse_curl_output, parse_curl_response, url_protected_by_cloudflare?, url_protected_by_incapsula?

Methods included from SystemCommand::Mixin

#system_command, #system_command!

Methods included from FormulaCellarChecks

#audit_installed, #check_binary_arches, #check_cpuid_instruction, #check_easy_install_pth, #check_elisp_dirname, #check_elisp_root, #check_env_path, #check_generic_executables, #check_infopages, #check_jars, #check_manpages, #check_non_executables, #check_non_libraries, #check_plist, #check_python_packages, #check_python_symlinks, #check_service_command, #check_shim_references, #valid_library_extension?

Methods included from OS::Linux::FormulaCellarChecks

#valid_library_extension?

Methods included from OS::Mac::FormulaCellarChecks

#audit_installed, #check_flat_namespace, #check_linkage, #check_openssl_links, #check_python_framework_links, #check_shadowed_headers, #valid_library_extension?

Constructor Details

#initialize(formula, new_formula: nil, strict: nil, online: nil, git: nil, display_cop_names: nil, only: nil, except: nil, style_offenses: nil, core_tap: nil, tap_audit: nil, spdx_license_data: nil, spdx_exception_data: nil) ⇒ void

This method is part of a private API. This method may only be used in the Homebrew/brew repository. Third parties should avoid using this method if possible, as it may be removed or changed without warning.

Parameters:

  • formula (Formula)
  • new_formula (Boolean, nil) (defaults to: nil)
  • strict (Boolean, nil) (defaults to: nil)
  • online (Boolean, nil) (defaults to: nil)
  • git (Boolean, nil) (defaults to: nil)
  • display_cop_names (Boolean, nil) (defaults to: nil)
  • only (Array<String>, nil) (defaults to: nil)
  • except (Array<String>, nil) (defaults to: nil)
  • style_offenses (Array<Style::Offense>, nil) (defaults to: nil)
  • core_tap (Boolean, nil) (defaults to: nil)
  • tap_audit (Boolean, nil) (defaults to: nil)
  • spdx_license_data (Hash{String => T.untyped}, nil) (defaults to: nil)
  • spdx_exception_data (Hash{String => T.untyped}, nil) (defaults to: nil)


51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
# File 'formula_auditor.rb', line 51

def initialize(formula, new_formula: nil, strict: nil, online: nil, git: nil, display_cop_names: nil, only: nil,
               except: nil, style_offenses: nil, core_tap: nil, tap_audit: nil, spdx_license_data: nil,
               spdx_exception_data: nil)
  @formula = formula
  @versioned_formula = T.let(formula.versioned_formula?, T::Boolean)
  @new_formula_inclusive = new_formula
  @new_formula = new_formula && !@versioned_formula
  @strict = strict
  @online = online
  @git = git
  @display_cop_names = display_cop_names
  @only = only
  @except = except
  # Accept precomputed style offense results, for efficiency
  @style_offenses = style_offenses
  # Allow the formula tap to be set as homebrew/core, for testing purposes
  @core_tap = T.let(formula.tap&.core_tap? || core_tap || false, T::Boolean)
  @problems = T.let([], T::Array[T.any(String, T::Hash[Symbol, T.untyped])])
  @new_formula_problems = T.let([], T::Array[T.any(String, T::Hash[Symbol, T.untyped])])
  @text = T.let(formula.path.open("rb", &:read), String)
  @specs = T.let(%w[stable head].filter_map { |s| formula.send(s) }, T::Array[SoftwareSpec])
  @spdx_license_data = spdx_license_data
  @spdx_exception_data = spdx_exception_data
  @tap_audit = tap_audit
  @committed_version_info_cache = T.let({}, T::Hash[String, T.untyped])
end

Instance Attribute Details

#formulaFormula (readonly)

This method is part of a private API. This method may only be used in the Homebrew/brew repository. Third parties should avoid using this method if possible, as it may be removed or changed without warning.

Returns:



23
24
25
# File 'formula_auditor.rb', line 23

def formula
  @formula
end

#new_formula_problemsArray<String, Hash{Symbol => T.untyped}> (readonly)

This method is part of a private API. This method may only be used in the Homebrew/brew repository. Third parties should avoid using this method if possible, as it may be removed or changed without warning.

Returns:



32
33
34
# File 'formula_auditor.rb', line 32

def new_formula_problems
  @new_formula_problems
end

#problemsArray<String, Hash{Symbol => T.untyped}> (readonly)

This method is part of a private API. This method may only be used in the Homebrew/brew repository. Third parties should avoid using this method if possible, as it may be removed or changed without warning.

Returns:



29
30
31
# File 'formula_auditor.rb', line 29

def problems
  @problems
end

#textString (readonly)

This method is part of a private API. This method may only be used in the Homebrew/brew repository. Third parties should avoid using this method if possible, as it may be removed or changed without warning.

Returns:



26
27
28
# File 'formula_auditor.rb', line 26

def text
  @text
end

Class Method Details

.aliasesArray<String>

This method is part of a private API. This method may only be used in the Homebrew/brew repository. Third parties should avoid using this method if possible, as it may be removed or changed without warning.

Returns:



175
176
177
178
# File 'formula_auditor.rb', line 175

def self.aliases
  # core aliases + tap alias names + tap alias full name
  @aliases ||= T.let(Formula.aliases + Formula.tap_aliases, T.nilable(T::Array[String]))
end

Instance Method Details

#auditvoid

This method is part of a private API. This method may only be used in the Homebrew/brew repository. Third parties should avoid using this method if possible, as it may be removed or changed without warning.

This method returns an undefined value.



1186
1187
1188
1189
1190
1191
1192
1193
1194
1195
1196
1197
# File 'formula_auditor.rb', line 1186

def audit
  only_audits = @only
  except_audits = @except

  methods.map(&:to_s).grep(/^audit_/).each do |audit_method_name|
    name = audit_method_name.delete_prefix("audit_")
    next if only_audits&.exclude?(name)
    next if except_audits&.include?(name)

    send(audit_method_name)
  end
end

#audit_bitbucket_repositoryvoid

This method is part of a private API. This method may only be used in the Homebrew/brew repository. Third parties should avoid using this method if possible, as it may be removed or changed without warning.

This method returns an undefined value.



778
779
780
781
782
783
784
785
786
787
# File 'formula_auditor.rb', line 778

def audit_bitbucket_repository
  user, repo = get_repo_data(%r{https?://bitbucket\.org/([^/]+)/([^/]+)/?.*}) if @new_formula
  return if user.blank? || repo.nil?

  self_submission = self_submission?(user)
  warning = SharedAudits.bitbucket(user, repo, self_submission:)
  return if warning.nil?

  new_formula_problem warning
end

#audit_bottle_specvoid

This method is part of a private API. This method may only be used in the Homebrew/brew repository. Third parties should avoid using this method if possible, as it may be removed or changed without warning.

This method returns an undefined value.



650
651
652
653
654
655
656
657
658
# File 'formula_auditor.rb', line 650

def audit_bottle_spec
  # special case: new versioned formulae should be audited
  return unless @new_formula_inclusive
  return unless @core_tap

  return unless formula.bottle_defined?

  new_formula_problem "New formulae in homebrew/core should not have a `bottle do` block"
end

#audit_compatibility_versionvoid

This method is part of a private API. This method may only be used in the Homebrew/brew repository. Third parties should avoid using this method if possible, as it may be removed or changed without warning.

This method returns an undefined value.



1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
# File 'formula_auditor.rb', line 1032

def audit_compatibility_version
  return unless @git

  tap = formula.tap
  return if tap.nil?
  return unless tap.git?

  _, base_ref_version_info = committed_version_info
  return if base_ref_version_info.empty?

  previous_compatibility_version = base_ref_version_info[:compatibility_version] || 0
  current_compatibility_version = formula.compatibility_version || previous_compatibility_version

  if current_compatibility_version < previous_compatibility_version
    problem "`compatibility_version` should not decrease " \
            "from #{previous_compatibility_version} to #{current_compatibility_version}"
    return
  elsif current_compatibility_version > (previous_compatibility_version + 1)
    problem "`compatibility_version` should only increment by 1"
    return
  end

  compatibility_increment = current_compatibility_version - previous_compatibility_version
  return if compatibility_increment.zero?
  return unless formula.valid_platform?

  dependent_revision_bumps = changed_formulae_paths(tap).filter_map do |path|
    changed_formula = Formulary.factory(path)
    next if changed_formula.name == formula.name

    dependencies = changed_formula.recursive_dependencies.map(&:name)
    # Only formulae that depend (recursively) on the audited formula can justify the bump.
    next unless dependencies.include?(formula.name)

    _, base_ref_dependent_version_info = committed_version_info(formula: changed_formula)
    previous_revision = base_ref_dependent_version_info[:revision] || 0
    current_revision = changed_formula.revision
    next if current_revision != previous_revision + 1

    changed_formula.name
  end
  return if dependent_revision_bumps.any?

  problem "`compatibility_version` increased from #{previous_compatibility_version} to " \
          "#{current_compatibility_version} but no recursive dependent formulae increased " \
          "`revision` by 1 in this PR. Only bump `compatibility_version` when at least one recursive " \
          "dependent needs a `revision` bump. " \
          "See #{Formatter.url("https://docs.brew.sh/Formula-Cookbook#compatibility_version")}."
end

#audit_conflictsvoid

This method is part of a private API. This method may only be used in the Homebrew/brew repository. Third parties should avoid using this method if possible, as it may be removed or changed without warning.

This method returns an undefined value.



526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
# File 'formula_auditor.rb', line 526

def audit_conflicts
  tap = formula.tap
  formula.conflicts.each do |conflict|
    conflicting_formula = Formulary.factory(conflict.name)
    next if tap != conflicting_formula.tap

    problem "Formula should not conflict with itself" if formula == conflicting_formula

    if T.must(tap).formula_renames.key?(conflict.name) || T.must(tap).aliases.include?(conflict.name)
      problem "Formula conflict should be declared using " \
              "canonical name (#{conflicting_formula.name}) instead of '#{conflict.name}'"
    end

    reverse_conflict_found = T.let(false, T::Boolean)
    conflicting_formula.conflicts.each do |reverse_conflict|
      reverse_conflict_formula = Formulary.factory(reverse_conflict.name)
      if T.must(tap).formula_renames.key?(reverse_conflict.name) ||
         T.must(tap).aliases.include?(reverse_conflict.name)
        problem "Formula #{conflicting_formula.name} conflict should be declared using " \
                "canonical name (#{reverse_conflict_formula.name}) instead of '#{reverse_conflict.name}'"
      end

      reverse_conflict_found ||= reverse_conflict_formula == formula
    end
    unless reverse_conflict_found
      problem "Formula #{conflicting_formula.name} should also have a conflict declared with #{formula.name}"
    end
  rescue TapFormulaUnavailableError
    # Don't complain about missing cross-tap conflicts.
    next
  rescue FormulaUnavailableError
    problem "Can't find conflicting formula #{conflict.name.inspect}."
  rescue TapFormulaAmbiguityError
    problem "Ambiguous conflicting formula #{conflict.name.inspect}."
  end
end

#audit_deprecate_disablevoid

This method is part of a private API. This method may only be used in the Homebrew/brew repository. Third parties should avoid using this method if possible, as it may be removed or changed without warning.

This method returns an undefined value.



1175
1176
1177
1178
# File 'formula_auditor.rb', line 1175

def audit_deprecate_disable
  error = SharedAudits.check_deprecate_disable_reason(formula)
  problem error if error
end

#audit_depsvoid

This method is part of a private API. This method may only be used in the Homebrew/brew repository. Third parties should avoid using this method if possible, as it may be removed or changed without warning.

This method returns an undefined value.



338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
# File 'formula_auditor.rb', line 338

def audit_deps
  @specs.each do |spec|
    # Check for things we don't like to depend on.
    # We allow non-Homebrew installs whenever possible.
    spec.declared_deps.each do |dep|
      begin
        dep_f = dep.to_formula
      rescue TapFormulaUnavailableError
        # Don't complain about missing cross-tap dependencies
        next
      rescue FormulaUnavailableError
        problem "Can't find dependency '#{dep.name}'."
        next
      rescue TapFormulaAmbiguityError
        problem "Ambiguous dependency '#{dep.name}'."
        next
      end

      if dep_f.oldnames.include?(Utils.name_from_full_name(dep.name))
        problem "Dependency '#{dep.name}' was renamed; use new name '#{dep_f.name}'."
      end

      if @core_tap &&
         @new_formula &&
         !dep.uses_from_macos? &&
         dep_f.keg_only? &&
         dep_f.keg_only_reason.provided_by_macos? &&
         dep_f.keg_only_reason.applicable? &&
         formula.requirements.none?(LinuxRequirement) &&
         !formula.tap&.audit_exception(:provided_by_macos_depends_on_allowlist, dep.name)
        new_formula_problem(
          "Dependency '#{dep.name}' is provided by macOS; " \
          "please replace 'depends_on' with 'uses_from_macos'.",
        )
      end

      dep.options.each do |opt|
        next if @core_tap
        next if dep_f.option_defined?(opt)
        next if dep_f.requirements.find do |r|
          if r.recommended?
            opt.name == "with-#{r.name}"
          elsif r.optional?
            opt.name == "without-#{r.name}"
          end
        end

        problem "Dependency '#{dep}' does not define option: #{opt.name.inspect}"
      end

      problem "Don't use 'git' as a dependency (it's always available)" if @new_formula && dep.name == "git"

      dep.tags.each do |tag|
        if [:run, :linked].include?(tag)
          problem "Dependency '#{dep.name}' is marked as :#{tag}. Remove :#{tag}; it is a no-op."
        elsif tag.is_a?(Symbol) && Dependable::RESERVED_TAGS.exclude?(tag)
          problem "Dependency '#{dep.name}' is marked as :#{tag} which is not a valid tag."
        end
      end

      next unless @core_tap

      if dep_f.tap.nil?
        problem <<~EOS
          Dependency '#{dep.name}' does not exist in any tap.
        EOS
      elsif !dep_f.tap!.core_tap?
        problem <<~EOS
          Dependency '#{dep.name}' is not in homebrew/core. Formulae in homebrew/core
          should not have dependencies in external taps.
        EOS
      end

      if dep_f.deprecated? && !formula.deprecated? && !formula.disabled?
        problem <<~EOS
          Dependency '#{dep.name}' is deprecated but has un-deprecated dependents. Either
          un-deprecate '#{dep.name}' or deprecate it and all of its dependents.
        EOS
      end

      if dep_f.disabled? && !formula.disabled?
        problem <<~EOS
          Dependency '#{dep.name}' is disabled but has un-disabled dependents. Either
          un-disable '#{dep.name}' or disable it and all of its dependents.
        EOS
      end

      # we want to allow uses_from_macos for aliases but not bare dependencies.
      # we also allow `pkg-config` for backwards compatibility in external taps.
      if self.class.aliases.include?(dep.name) && !dep.uses_from_macos? && (dep.name != "pkg-config" || @core_tap)
        problem "Dependency '#{dep.name}' is an alias; use the canonical name '#{dep.to_formula.full_name}'."
      end

      if dep.tags.include?(:recommended) || dep.tags.include?(:optional)
        problem "Formulae in homebrew/core should not have optional or recommended dependencies"
      end
    end

    next unless @core_tap

    if spec.requirements.map(&:recommended?).any? || spec.requirements.map(&:optional?).any?
      problem "Formulae in homebrew/core should not have optional or recommended requirements"
    end
  end

  return unless @core_tap
  return if formula.tap&.audit_exception :versioned_dependencies_conflicts_allowlist, formula.name

  # The number of conflicts on Linux is absurd.
  # TODO: remove this and check these there too.
  return if Homebrew::SimulateSystem.simulating_or_running_on_linux?

  # Skip the versioned dependencies conflict audit for *-staging branches.
  # This will allow us to migrate dependents of formulae like Python or OpenSSL
  # gradually over separate PRs which target a *-staging branch. See:
  #   https://github.com/Homebrew/homebrew-core/pull/134260
  ignore_formula_conflict, staging_formula =
    if @tap_audit && (github_event_path = ENV.fetch("GITHUB_EVENT_PATH", nil)).present?
      event_payload = JSON.parse(File.read(github_event_path))
      base_info = event_payload.dig("pull_request", "base").to_h # handle `nil`

      # We need to read the head ref from `GITHUB_EVENT_PATH` because
      # `git branch --show-current` returns the default branch on PR branches.
      staging_branch = base_info["ref"]&.end_with?("-staging")
      homebrew_owned_repo = base_info.dig("repo", "owner", "login") == "Homebrew"
      homebrew_core_pr = base_info.dig("repo", "name") == "homebrew-core"
      # Support staging branches named `formula-staging` or `formula@version-staging`.
      base_formula = base_info["ref"]&.split(/-|@/, 2)&.first

      [staging_branch && homebrew_owned_repo && homebrew_core_pr, base_formula]
    end

  recursive_runtime_formulae = formula.runtime_formula_dependencies(undeclared: false)
  version_hash = {}
  version_conflicts = Set.new
  recursive_runtime_formulae.each do |f|
    name = f.name
    unversioned_name = name.split("@").fetch(0)
    next if ignore_formula_conflict && unversioned_name == staging_formula
    # Allow use of the full versioned name (e.g. `python@3.99`) or an unversioned alias (`python`).
    next if formula.tap&.audit_exception :versioned_formula_dependent_conflicts_allowlist, name
    next if formula.tap&.audit_exception :versioned_formula_dependent_conflicts_allowlist, unversioned_name

    version_hash[unversioned_name] ||= Set.new
    version_hash[unversioned_name] << name
    next if version_hash[unversioned_name].length < 2

    version_conflicts += version_hash[unversioned_name]
  end

  return if version_conflicts.empty?

  return if formula.disabled?

  return if formula.deprecated? &&
            formula.deprecation_reason != DeprecateDisable::FORMULA_DEPRECATE_DISABLE_REASONS[:versioned_formula]

  problem <<~EOS
    #{formula.full_name} contains conflicting version recursive dependencies:
      #{version_conflicts.to_a.join ", "}
    View these with `brew deps --tree #{formula.full_name}`.
  EOS
end

#audit_eolvoid

This method is part of a private API. This method may only be used in the Homebrew/brew repository. Third parties should avoid using this method if possible, as it may be removed or changed without warning.

This method returns an undefined value.



661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
# File 'formula_auditor.rb', line 661

def audit_eol
  return unless @online
  return unless @core_tap

  return if formula.deprecated? || formula.disabled?

  name = if formula.versioned_formula?
    formula.name.split("@").fetch(0)
  else
    formula.name
  end

  return if formula.tap&.audit_exception :eol_date_blocklist, name

   = SharedAudits.eol_data(name, formula.version.major.to_s)
   ||= SharedAudits.eol_data(name, formula.version.major_minor.to_s)

  return if .blank? || (.dig("result", "isEol") != true)

  eol_from = .dig("result", "eolFrom")
  eol_date = Date.parse(eol_from) if eol_from.present?

  message = "Product is EOL"
  message += " since #{eol_date}" if eol_date.present?
  message += ", see #{Formatter.url("https://endoflife.date/#{name}")}"

  problem message
end

#audit_filevoid

This method is part of a private API. This method may only be used in the Homebrew/brew repository. Third parties should avoid using this method if possible, as it may be removed or changed without warning.

This method returns an undefined value.



91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
# File 'formula_auditor.rb', line 91

def audit_file
  if formula.core_formula? && @versioned_formula
    unversioned_name = formula.name.gsub(/@.*$/, "")

    # ignore when an unversioned formula doesn't exist after an explicit rename
    return if formula.tap!.formula_renames.key?(unversioned_name)

    # build this ourselves as we want e.g. homebrew/core to be present
    full_name = "#{formula.tap!}/#{unversioned_name}"

    unversioned_formula = begin
      Formulary.factory(full_name).path
    rescue FormulaUnavailableError, TapFormulaAmbiguityError
      Pathname.new formula.path.to_s.gsub(/@.*\.rb$/, ".rb")
    end
    unless unversioned_formula.exist?
      unversioned_name = unversioned_formula.basename(".rb")
      problem "#{formula} is versioned but no #{unversioned_name} formula exists"
    end
  elsif formula.stable? &&
        !@versioned_formula &&
        (versioned_formulae = formula.versioned_formulae - [formula]) &&
        versioned_formulae.present?
    versioned_aliases, unversioned_aliases = formula.aliases.partition { |a| /.@\d/.match?(a) }
    last_alias_version = versioned_formulae.map(&:name).fetch(-1).split("@").fetch(-1)

    alias_name_major = "#{formula.name}@#{formula.version.major}"
    alias_name_major_minor = "#{formula.name}@#{formula.version.major_minor}"
    alias_name = if last_alias_version.split(".").length == 1
      alias_name_major
    else
      alias_name_major_minor
    end
    valid_main_alias_names = [alias_name_major, alias_name_major_minor].uniq

    # Also accept versioned aliases with names of other aliases, but do not require them.
    valid_other_alias_names = unversioned_aliases.flat_map do |name|
      %W[
        #{name}@#{formula.version.major}
        #{name}@#{formula.version.major_minor}
      ].uniq
    end

    unless @core_tap
      [versioned_aliases, valid_main_alias_names, valid_other_alias_names].each do |array|
        array.map! { |a| "#{formula.tap}/#{a}" }
      end
    end

    valid_versioned_aliases = versioned_aliases & valid_main_alias_names
    invalid_versioned_aliases = versioned_aliases - valid_main_alias_names - valid_other_alias_names

    latest_versioned_formula = versioned_formulae.map(&:name).first

    if valid_versioned_aliases.empty? && alias_name != latest_versioned_formula
      if formula.tap
        problem <<~EOS
          Formula has other versions so create a versioned alias:
            cd #{formula.tap!.alias_dir}
            ln -s #{formula.path.to_s.gsub(formula.tap!.path.to_s, "..")} #{alias_name}
        EOS
      else
        problem "Formula has other versions so create an alias named '#{alias_name}'."
      end
    end

    if invalid_versioned_aliases.present?
      problem <<~EOS
        Formula has invalid versioned aliases:
          #{invalid_versioned_aliases.join("\n  ")}
      EOS
    end
  end

  return if !formula.core_formula? || formula.path == formula.tap!.new_formula_path(formula.name)

  problem <<~EOS
    Formula is in wrong path:
      Expected: #{formula.tap!.new_formula_path(formula.name)}
        Actual: #{formula.path}
  EOS
end

#audit_forgejo_repositoryvoid

This method is part of a private API. This method may only be used in the Homebrew/brew repository. Third parties should avoid using this method if possible, as it may be removed or changed without warning.

This method returns an undefined value.



790
791
792
793
794
795
796
797
798
799
# File 'formula_auditor.rb', line 790

def audit_forgejo_repository
  user, repo = get_repo_data(%r{https?://codeberg\.org/([^/]+)/([^/]+)/?.*}) if @new_formula
  return if user.blank? || repo.nil?

  self_submission = self_submission?(user)
  warning = SharedAudits.forgejo(user, repo, self_submission:)
  return if warning.nil?

  new_formula_problem warning
end

#audit_forgejo_repository_archivedvoid

This method is part of a private API. This method may only be used in the Homebrew/brew repository. Third parties should avoid using this method if possible, as it may be removed or changed without warning.

This method returns an undefined value.



740
741
742
743
744
745
746
747
748
749
750
# File 'formula_auditor.rb', line 740

def audit_forgejo_repository_archived
  return if formula.deprecated? || formula.disabled?

  user, repo = get_repo_data(%r{https?://codeberg\.org/([^/]+)/([^/]+)/?.*}) if @online
  return if user.blank? || repo.nil?

   = SharedAudits.forgejo_repo_data(user, repo)
  return if .nil?

  problem "Forgejo repository is archived since #{["archived_at"]}" if ["archived"]
end

#audit_gcc_dependencyvoid

This method is part of a private API. This method may only be used in the Homebrew/brew repository. Third parties should avoid using this method if possible, as it may be removed or changed without warning.

This method returns an undefined value.



564
565
566
567
568
569
570
571
572
573
# File 'formula_auditor.rb', line 564

def audit_gcc_dependency
  return unless @core_tap
  return unless Homebrew::SimulateSystem.simulating_or_running_on_linux?
  return unless linux_only_gcc_dep?(formula)
  # https://github.com/Homebrew/homebrew-core/pull/171634
  # https://github.com/nghttp2/nghttp2/issues/2194
  return if formula.tap&.audit_exception(:linux_only_gcc_dependency_allowlist, formula.name)

  problem "Formulae in homebrew/core should not have a Linux-only dependency on GCC."
end

#audit_github_repositoryvoid

This method is part of a private API. This method may only be used in the Homebrew/brew repository. Third parties should avoid using this method if possible, as it may be removed or changed without warning.

This method returns an undefined value.



753
754
755
756
757
758
759
760
761
762
763
# File 'formula_auditor.rb', line 753

def audit_github_repository
  user, repo = get_repo_data(%r{https?://github\.com/([^/]+)/([^/]+)/?.*}) if @new_formula

  return if user.blank? || repo.nil?

  self_submission = self_submission?(user)
  warning = SharedAudits.github(user, repo, self_submission:)
  return if warning.nil?

  new_formula_problem warning
end

#audit_github_repository_archivedvoid

This method is part of a private API. This method may only be used in the Homebrew/brew repository. Third parties should avoid using this method if possible, as it may be removed or changed without warning.

This method returns an undefined value.



714
715
716
717
718
719
720
721
722
723
724
# File 'formula_auditor.rb', line 714

def audit_github_repository_archived
  return if formula.deprecated? || formula.disabled?

  user, repo = get_repo_data(%r{https?://github\.com/([^/]+)/([^/]+)/?.*}) if @online
  return if user.blank? || repo.nil?

   = SharedAudits.github_repo_data(user, repo)
  return if .nil?

  problem "GitHub repository is archived" if ["archived"]
end

#audit_gitlab_repositoryvoid

This method is part of a private API. This method may only be used in the Homebrew/brew repository. Third parties should avoid using this method if possible, as it may be removed or changed without warning.

This method returns an undefined value.



766
767
768
769
770
771
772
773
774
775
# File 'formula_auditor.rb', line 766

def audit_gitlab_repository
  user, repo = get_repo_data(%r{https?://gitlab\.com/([^/]+)/([^/]+)/?.*}) if @new_formula
  return if user.blank? || repo.nil?

  self_submission = self_submission?(user)
  warning = SharedAudits.gitlab(user, repo, self_submission:)
  return if warning.nil?

  new_formula_problem warning
end

#audit_gitlab_repository_archivedvoid

This method is part of a private API. This method may only be used in the Homebrew/brew repository. Third parties should avoid using this method if possible, as it may be removed or changed without warning.

This method returns an undefined value.



727
728
729
730
731
732
733
734
735
736
737
# File 'formula_auditor.rb', line 727

def audit_gitlab_repository_archived
  return if formula.deprecated? || formula.disabled?

  user, repo = get_repo_data(%r{https?://gitlab\.com/([^/]+)/([^/]+)/?.*}) if @online
  return if user.blank? || repo.nil?

   = SharedAudits.gitlab_repo_data(user, repo)
  return if .nil?

  problem "GitLab repository is archived" if ["archived"]
end

#audit_glibcvoid

This method is part of a private API. This method may only be used in the Homebrew/brew repository. Third parties should avoid using this method if possible, as it may be removed or changed without warning.

This method returns an undefined value.



576
577
578
579
580
581
582
583
584
585
# File 'formula_auditor.rb', line 576

def audit_glibc
  return unless @core_tap
  return if formula.name != "glibc"
  # Also allow LINUX_GLIBC_NEXT_CI_VERSION for when we're upgrading.
  return if [OS::LINUX_GLIBC_CI_VERSION, OS::LINUX_GLIBC_NEXT_CI_VERSION].include?(formula.version.to_s)

  problem "The glibc version must be #{OS::LINUX_GLIBC_CI_VERSION}, as needed by our CI on Linux. " \
          "The glibc formula is for users who have a system glibc with a lower version, " \
          "which allows them to use our Linux bottles, which were compiled against system glibc on CI."
end

#audit_homepagevoid

This method is part of a private API. This method may only be used in the Homebrew/brew repository. Third parties should avoid using this method if possible, as it may be removed or changed without warning.

This method returns an undefined value.



615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
# File 'formula_auditor.rb', line 615

def audit_homepage
  homepage = formula.homepage

  return if homepage.blank?

  return unless @online

  return if formula.tap&.audit_exception :cert_error_allowlist, formula.name, homepage

  return unless DevelopmentTools.curl_handles_most_https_certificates?

  # Skip gnu.org and nongnu.org audit on GitHub runners
  # See issue: https://github.com/Homebrew/homebrew-core/issues/206757
  github_runner = GitHub::Actions.env_set? && !ENV["GITHUB_ACTIONS_HOMEBREW_SELF_HOSTED"]
  return if homepage.match?(%r{^https?://www\.(?:non)?gnu\.org/.+}) && github_runner

  use_homebrew_curl = [:stable, :head].any? do |spec_name|
    next false unless (spec = formula.send(spec_name))

    spec.using == :homebrew_curl
  end

  if (http_content_problem = curl_check_http_content(
    homepage,
    SharedAudits::URL_TYPE_HOMEPAGE,
    user_agents:       [:browser, :default],
    check_content:     true,
    strict:            @strict || false,
    use_homebrew_curl:,
  ))
    problem http_content_problem
  end
end

#audit_licensevoid

This method is part of a private API. This method may only be used in the Homebrew/brew repository. Third parties should avoid using this method if possible, as it may be removed or changed without warning.

This method returns an undefined value.



266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
# File 'formula_auditor.rb', line 266

def audit_license
  if formula.license.present?
    licenses, exceptions = SPDX.parse_license_expression formula.license

    incompatible_licenses = licenses.select do |license|
      license.to_s.start_with?(*INCOMPATIBLE_LICENSE_PREFIXES) || INCOMPATIBLE_LICENSES.include?(license.to_s)
    end
    if incompatible_licenses.present? && @core_tap
      problem <<~EOS
        Formula #{formula.name} contains incompatible licenses: #{incompatible_licenses}.
        Formulae in homebrew/core must either use a Debian Free Software Guidelines license
        or be released into the public domain: #{Formatter.url("https://docs.brew.sh/License-Guidelines")}
      EOS
    end

    non_standard_licenses = licenses.reject { |license| SPDX.valid_license? license }
    if non_standard_licenses.present?
      problem <<~EOS
        Formula #{formula.name} contains non-standard SPDX licenses: #{non_standard_licenses}.
        For a list of valid licenses check: #{Formatter.url("https://spdx.org/licenses/")}
      EOS
    end

    if @strict || @core_tap
      deprecated_licenses = licenses.select do |license|
        SPDX.deprecated_license? license
      end
      if deprecated_licenses.present?
        problem <<~EOS
          Formula #{formula.name} contains deprecated SPDX licenses: #{deprecated_licenses}.
          You may need to add `-only` or `-or-later` for GNU licenses (e.g. `GPL`, `LGPL`, `AGPL`, `GFDL`).
          For a list of valid licenses check: #{Formatter.url("https://spdx.org/licenses/")}
        EOS
      end
    end

    invalid_exceptions = exceptions.reject { |exception| SPDX.valid_license_exception? exception }
    if invalid_exceptions.present?
      problem <<~EOS
        Formula #{formula.name} contains invalid or deprecated SPDX license exceptions: #{invalid_exceptions}.
        For a list of valid license exceptions check:
          #{Formatter.url("https://spdx.org/licenses/exceptions-index.html")}
      EOS
    end

    return unless @online

    user, repo = get_repo_data(%r{https?://github\.com/([^/]+)/([^/]+)/?.*})
    return if user.blank? || repo.blank?

    stable = formula.stable
    raise "Stable is nil for formula #{formula.name}" if stable.nil?

    url = stable.url
    raise "Stable URL is nil for formula #{formula.name}" if url.nil?

    tag = SharedAudits.github_tag_from_url(url)
    tag ||= stable.specs[:tag]
    github_license = GitHub.get_repo_license(user, repo, ref: tag)
    return unless github_license
    return if (licenses + ["NOASSERTION"]).include?(github_license)
    return if PERMITTED_LICENSE_MISMATCHES[github_license]&.any? { |license| licenses.include? license }
    return if formula.tap&.audit_exception :permitted_formula_license_mismatches, formula.name

    problem "Formula license #{licenses} does not match GitHub license #{Array(github_license)}."

  elsif @core_tap && !formula.disabled?
    problem "Formulae in homebrew/core must specify a license."
  end
end

#audit_namevoid

This method is part of a private API. This method may only be used in the Homebrew/brew repository. Third parties should avoid using this method if possible, as it may be removed or changed without warning.

This method returns an undefined value.



203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
# File 'formula_auditor.rb', line 203

def audit_name
  name = formula.name

  name_auditor = Homebrew::FormulaNameCaskTokenAuditor.new(name)
  if (errors = name_auditor.errors).any?
    problem "Formula name '#{name}' must not contain #{errors.to_sentence(two_words_connector: " or ",
                                                                          last_word_connector: " or ")}."
  end

  return unless @core_tap
  return unless @strict

  problem "'#{name}' is not allowed in homebrew/core." if MissingFormula.disallowed_reason(name)

  if Formula.aliases.include? name
    problem "Formula name conflicts with existing aliases in homebrew/core."
    return
  end

  if (oldname = CoreTap.instance.formula_renames[name])
    problem "'#{name}' is reserved as the old name of #{oldname} in homebrew/core."
    return
  end

  cask_tokens = CoreCaskTap.instance.cask_tokens.presence
  cask_tokens ||= Homebrew::API.cask_tokens

  if cask_tokens.include?(name)
    problem "Formula name conflicts with an existing Homebrew/cask cask's token."
    return
  end

  return if formula.core_formula?
  return unless Formula.core_names.include?(name)

  problem "Formula name conflicts with an existing formula in homebrew/core."
end

#audit_node_modulesvoid

This method is part of a private API. This method may only be used in the Homebrew/brew repository. Third parties should avoid using this method if possible, as it may be removed or changed without warning.

This method returns an undefined value.



503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
# File 'formula_auditor.rb', line 503

def audit_node_modules
  return unless @core_tap

  node_modules = formula.libexec/"lib/node_modules"
  return unless node_modules.directory?

  incompatible_license_packages = %w[
    @anthropic-ai/claude-agent-sdk
    @github/copilot
  ]

  incompatible_license_packages.each do |package|
    # Search for package in all nested node_modules. Also including dot match for .pnpm hoisted packages
    next if node_modules.glob("{**/node_modules/,}#{package}/", File::FNM_DOTMATCH).empty?

    problem <<~EOS
      Formula #{formula.name} uses #{package} which has an incompatible license.
      All installed npm dependencies must satisfy #{Formatter.url("https://docs.brew.sh/License-Guidelines")}
    EOS
  end
end

#audit_prefix_has_contentsvoid

This method is part of a private API. This method may only be used in the Homebrew/brew repository. Third parties should avoid using this method if possible, as it may be removed or changed without warning.

This method returns an undefined value.



1163
1164
1165
1166
1167
1168
1169
1170
1171
1172
# File 'formula_auditor.rb', line 1163

def audit_prefix_has_contents
  return unless formula.prefix.directory?
  return unless Keg.new(formula.prefix).empty_installation?

  problem <<~EOS
    The installation seems to be empty. Please ensure the prefix
    is set correctly and expected files are installed.
    The prefix configure/make argument may be case-sensitive.
  EOS
end

#audit_relicensed_formulaevoid

This method is part of a private API. This method may only be used in the Homebrew/brew repository. Third parties should avoid using this method if possible, as it may be removed or changed without warning.

This method returns an undefined value.



588
589
590
591
592
593
594
595
596
597
# File 'formula_auditor.rb', line 588

def audit_relicensed_formulae
  return unless @core_tap

  relicensed_version = formula.tap&.audit_exception :relicensed_formulae_versions, formula.name
  return unless relicensed_version.is_a?(String)
  return if formula.version < Version.new(relicensed_version)

  problem "#{formula.name} was relicensed to a non-open-source license from version #{relicensed_version}. " \
          "It must not be upgraded to version #{relicensed_version} or newer."
end

#audit_reverse_migrationvoid

This method is part of a private API. This method may only be used in the Homebrew/brew repository. Third parties should avoid using this method if possible, as it may be removed or changed without warning.

This method returns an undefined value.



1149
1150
1151
1152
1153
1154
1155
1156
1157
1158
1159
1160
# File 'formula_auditor.rb', line 1149

def audit_reverse_migration
  # Only enforce for new formula being re-added to core
  return unless @strict
  return unless @core_tap
  return unless formula.tap!.tap_migrations.key?(formula.name)

  problem <<~EOS
    #{formula.name} seems to be listed in tap_migrations.json!
    Please remove #{formula.name} from present tap & tap_migrations.json
    before submitting it to Homebrew/homebrew-#{formula.tap!.repository}.
  EOS
end

#audit_revisionvoid

This method is part of a private API. This method may only be used in the Homebrew/brew repository. Third parties should avoid using this method if possible, as it may be removed or changed without warning.

This method returns an undefined value.



968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
# File 'formula_auditor.rb', line 968

def audit_revision
  new_formula_problem("New formulae should not define a revision.") if @new_formula && !formula.revision.zero?

  return unless @git

  tap = formula.tap
  return if tap.nil?
  return unless tap.git?
  return if formula.stable.blank?

  current_version = T.must(formula.stable).version
  current_revision = formula.revision

  previous_version_info, base_ref_version_info = committed_version_info

  previous_version = previous_version_info[:version]
  previous_revision = previous_version_info[:revision]
  base_ref_version = base_ref_version_info[:version]
  base_ref_revision = base_ref_version_info[:revision]

  if (previous_version != base_ref_version || current_version != base_ref_version) &&
     !current_revision.zero? && current_revision == base_ref_revision && current_revision == previous_revision
    problem "`revision #{current_revision}` should be removed"
  elsif current_version == previous_version && previous_revision && current_revision < previous_revision
    problem "`revision` should not decrease (from #{previous_revision} to #{current_revision})"
  elsif base_ref_revision && current_revision > (base_ref_revision + 1)
    problem "`revision` should only increment by 1"
  end

  revision_increment = current_revision - previous_revision.to_i
  return if revision_increment != 1

  dependency_names = formula.recursive_dependencies.map(&:name)
  return if dependency_names.empty?

  changed_dependency_paths = changed_formulae_paths(tap, only_names: dependency_names)
  return if changed_dependency_paths.empty?

  missing_compatibility_bumps = changed_dependency_paths.filter_map do |path|
    changed_formula = Formulary.factory(path)
    # Each changed dependency that updates its version must raise its compatibility_version by exactly one.
    _, base_ref_dependency_version_info = committed_version_info(formula: changed_formula)
    previous_dependency_version = base_ref_dependency_version_info[:version]
    current_dependency_version = changed_formula.stable&.version
    if previous_dependency_version.present? && current_dependency_version.present? &&
       current_dependency_version == previous_dependency_version
      next
    end

    previous_compatibility_version = base_ref_dependency_version_info[:compatibility_version] || 0
    current_compatibility_version = changed_formula.compatibility_version || 0
    next if current_compatibility_version == previous_compatibility_version + 1

    expected_compatibility_version = previous_compatibility_version + 1
    "#{changed_formula.name} (#{previous_compatibility_version} to #{expected_compatibility_version})"
  end
  return if missing_compatibility_bumps.empty? || !formula.core_formula?

  problem "`revision` increased but changed recursive dependencies must increase `compatibility_version` by 1 " \
          "in the same PR: #{missing_compatibility_bumps.join(", ")}. " \
          "See #{Formatter.url("https://docs.brew.sh/Formula-Cookbook#compatibility_version")}."
end

#audit_specsvoid

This method is part of a private API. This method may only be used in the Homebrew/brew repository. Third parties should avoid using this method if possible, as it may be removed or changed without warning.

This method returns an undefined value.



817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
# File 'formula_auditor.rb', line 817

def audit_specs
  problem "HEAD-only (no stable download)" if head_only?(formula) && @core_tap

  %w[Stable HEAD].each do |name|
    spec_name = name.downcase.to_sym
    next unless (spec = formula.send(spec_name))

    except = @except.to_a
    if spec_name == :head &&
       formula.tap&.audit_exception(:head_non_default_branch_allowlist, formula.name, spec.specs[:branch])
      except << "head_branch"
    end

    ra = ResourceAuditor.new(
      spec, spec_name,
      online: @online, strict: @strict, only: @only, core_tap: @core_tap, except:,
      use_homebrew_curl: spec.using == :homebrew_curl
    ).audit
    ra.problems.each do |message|
      problem "#{name}: #{message}"
    end

    spec.resources.each_value do |resource|
      problem "Resource name should be different from the formula name" if resource.name == formula.name

      ra = ResourceAuditor.new(
        resource, spec_name,
        online: @online, strict: @strict, only: @only, except: @except,
        use_homebrew_curl: resource.using == :homebrew_curl
      ).audit
      ra.problems.each do |message|
        problem "#{name} resource #{resource.name.inspect}: #{message}"
      end
    end

    next if spec.patches.empty?
    next if !@new_formula || !@core_tap

    new_formula_problem(
      "Formulae should not require patches to build. " \
      "Patches should be submitted and accepted upstream first.",
    )
  end

  return unless @core_tap

  if formula.head && @versioned_formula &&
     !formula.tap&.audit_exception(:versioned_head_spec_allowlist, formula.name)
    problem "Versioned formulae should not have a `head` spec"
  end

  stable = formula.stable
  return unless stable
  return unless (url = stable.url)

  version = stable.version
  problem "Stable: version (#{version}) is set to a string without a digit" unless /\d/.match?(version.to_s)

  stable_version_string = version.to_s
  if stable_version_string.start_with?("HEAD")
    problem "Stable: non-HEAD version (#{stable_version_string}) should not begin with `HEAD`"
  end

  stable_url_version = Version.parse(url)
  stable_url_minor_version = stable_url_version.minor.to_i

  formula_suffix = stable.version.patch.to_i
  throttled_rate = formula.livecheck.throttle
  if throttled_rate && formula_suffix.modulo(throttled_rate).nonzero?
    problem "Should only be updated every #{throttled_rate} releases on multiples of #{throttled_rate}"
  end

  case url
  when /[\d._-](alpha|beta|rc\d)/
    matched = Regexp.last_match(1)
    version_prefix = stable_version_string.sub(/\d+$/, "")
    return if formula.tap&.audit_exception :unstable_allowlist, formula.name, version_prefix
    return if formula.tap&.audit_exception :unstable_devel_allowlist, formula.name, version_prefix

    problem "Stable: version URLs should not contain `#{matched}`"
  when %r{download\.gnome\.org/sources}, %r{ftp\.gnome\.org/pub/GNOME/sources}i
    version_prefix = stable.version.major_minor
    return if formula.tap&.audit_exception :gnome_devel_allowlist, formula.name, version_prefix
    return if formula.tap&.audit_exception :gnome_devel_allowlist, formula.name, "all"
    return if stable_url_version < Version.new("1.0")
    # All minor versions are stable in the new GNOME version scheme (which starts at version 40.0)
    # https://discourse.gnome.org/t/new-gnome-versioning-scheme/4235
    return if stable_url_version >= Version.new("40.0")
    return if stable_url_minor_version.even?

    problem "Stable: version (#{stable.version}) is a development release"
  when %r{isc.org/isc/bind\d*/}i
    return if stable_url_minor_version.even?

    problem "Stable: version (#{stable.version}) is a development release"

  when %r{https?://gitlab\.com/([\w-]+)/([\w-]+)}
    owner = T.must(Regexp.last_match(1))
    repo = T.must(Regexp.last_match(2))

    tag = SharedAudits.gitlab_tag_from_url(url)
    tag ||= stable.specs[:tag]
    tag ||= stable.version.to_s

    if @online
      error = SharedAudits.gitlab_release(owner, repo, tag, formula:)
      problem error if error
    end
  when %r{^https://github.com/([\w-]+)/([\w-]+)}
    owner = T.must(Regexp.last_match(1))
    repo = T.must(Regexp.last_match(2))
    tag = SharedAudits.github_tag_from_url(url)
    tag ||= formula.stable&.specs&.[](:tag)

    if @online && !tag.nil?
      error = SharedAudits.github_release(owner, repo, tag, formula:)
      problem error if error
    end
  when %r{^https://codeberg\.org/([\w-]+)/([\w-]+)}
    owner = T.must(Regexp.last_match(1))
    repo = T.must(Regexp.last_match(2))
    tag = SharedAudits.forgejo_tag_from_url(url)
    tag ||= formula.stable&.specs&.[](:tag)

    if @online && !tag.nil?
      error = SharedAudits.forgejo_release(owner, repo, tag, formula:)
      problem error if error
    end
  end
end

#audit_stable_versionvoid

This method is part of a private API. This method may only be used in the Homebrew/brew repository. Third parties should avoid using this method if possible, as it may be removed or changed without warning.

This method returns an undefined value.



949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
# File 'formula_auditor.rb', line 949

def audit_stable_version
  return unless @git
  return unless formula.tap # skip formula not from core or any taps
  return unless formula.tap!.git? # git log is required
  return if formula.stable.blank?

  current_version = T.must(formula.stable).version
  current_version_scheme = formula.version_scheme

  previous_version_info, base_ref_version_info = committed_version_info

  if (base_ref_version = base_ref_version_info[:version]) &&
     current_version < base_ref_version &&
     current_version_scheme == previous_version_info[:version_scheme]
    problem "Stable: version should not decrease (from #{base_ref_version} to #{current_version})"
  end
end

#audit_stylevoid

This method is part of a private API. This method may only be used in the Homebrew/brew repository. Third parties should avoid using this method if possible, as it may be removed or changed without warning.

This method returns an undefined value.



79
80
81
82
83
84
85
86
87
88
# File 'formula_auditor.rb', line 79

def audit_style
  return unless @style_offenses

  @style_offenses.each do |offense|
    cop_name = "#{offense.cop_name}: " if @display_cop_names
    message = "#{cop_name}#{offense.message}"

    problem message, location: offense.location, corrected: offense.corrected?
  end
end

#audit_synced_versions_formulaevoid

This method is part of a private API. This method may only be used in the Homebrew/brew repository. Third parties should avoid using this method if possible, as it may be removed or changed without warning.

This method returns an undefined value.



181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
# File 'formula_auditor.rb', line 181

def audit_synced_versions_formulae
  return unless formula.synced_with_other_formulae?

  name = formula.name
  version = formula.version

  formula.tap!.synced_versions_formulae.each do |synced_version_formulae|
    next unless synced_version_formulae.include?(name)

    synced_version_formulae.each do |synced_formula|
      next if synced_formula == name

      if (synced_version = Formulary.factory(synced_formula).version) != version
        problem "Version of #{synced_formula} (#{synced_version}) should match version of #{name} (#{version})"
      end
    end

    break
  end
end

#audit_textvoid

This method is part of a private API. This method may only be used in the Homebrew/brew repository. Third parties should avoid using this method if possible, as it may be removed or changed without warning.

This method returns an undefined value.



1129
1130
1131
1132
1133
1134
1135
1136
1137
1138
1139
1140
1141
1142
1143
1144
1145
1146
# File 'formula_auditor.rb', line 1129

def audit_text
  bin_names = Set.new
  bin_names << formula.name
  bin_names += formula.aliases
  [formula.bin, formula.sbin].each do |dir|
    next unless dir.exist?

    bin_names += dir.children.map { |child| child.basename.to_s }
  end
  shell_commands = ["system", "shell_output", "pipe_output"]
  bin_names.each do |name|
    shell_commands.each do |cmd|
      if text.to_s.match?(/test do.*#{cmd}[(\s]+['"]#{Regexp.escape(name)}[\s'"]/m)
        problem %Q(Fully scope test `#{cmd}` calls, e.g.: #{cmd} "\#{bin}/#{name}")
      end
    end
  end
end

#audit_unconfirmed_checksum_changevoid

This method is part of a private API. This method may only be used in the Homebrew/brew repository. Third parties should avoid using this method if possible, as it may be removed or changed without warning.

This method returns an undefined value.



1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
# File 'formula_auditor.rb', line 1103

def audit_unconfirmed_checksum_change
  return unless @git
  return unless formula.tap # skip formula not from core or any taps
  return unless formula.tap!.git? # git log is required
  return unless (current_stable = formula.stable)

  current_version = current_stable.version
  current_checksum = current_stable.checksum
  current_url = current_stable.url

  _, base_ref_version_info = committed_version_info
  base_ref_checksum = base_ref_version_info[:checksum]

  if current_version == base_ref_version_info[:version] &&
     current_url == base_ref_version_info[:url] &&
     current_checksum.present? && base_ref_checksum.present? &&
     current_checksum != base_ref_checksum
    problem(
      "stable sha256 changed without the url/version also changing; " \
      "please create an issue upstream to rule out malicious " \
      "circumstances and to find out why the file changed.",
    )
  end
end

#audit_version_schemevoid

This method is part of a private API. This method may only be used in the Homebrew/brew repository. Third parties should avoid using this method if possible, as it may be removed or changed without warning.

This method returns an undefined value.



1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
# File 'formula_auditor.rb', line 1083

def audit_version_scheme
  return unless @git
  return unless formula.tap # skip formula not from core or any taps
  return unless formula.tap!.git? # git log is required
  return if formula.stable.blank?

  current_version_scheme = formula.version_scheme

  _, base_ref_version_info = committed_version_info
  previous_version_scheme = base_ref_version_info[:version_scheme]
  return if previous_version_scheme.nil?

  if current_version_scheme < previous_version_scheme
    problem "`version_scheme` should not decrease (from #{previous_version_scheme} to #{current_version_scheme})"
  elsif current_version_scheme > (previous_version_scheme + 1)
    problem "`version_scheme` should only increment by 1"
  end
end

#audit_versioned_keg_onlyvoid

This method is part of a private API. This method may only be used in the Homebrew/brew repository. Third parties should avoid using this method if possible, as it may be removed or changed without warning.

This method returns an undefined value.



600
601
602
603
604
605
606
607
608
609
610
611
612
# File 'formula_auditor.rb', line 600

def audit_versioned_keg_only
  return unless @versioned_formula
  return unless @core_tap

  if formula.keg_only?
    return if formula.keg_only_reason.versioned_formula?
    return if formula.name.start_with?("openssl", "libressl") && formula.keg_only_reason.by_macos?
  end

  return if formula.tap&.audit_exception :versioned_keg_only_allowlist, formula.name

  problem "Versioned formulae in homebrew/core should use `keg_only :versioned_formula`"
end

#audit_wayback_urlvoid

This method is part of a private API. This method may only be used in the Homebrew/brew repository. Third parties should avoid using this method if possible, as it may be removed or changed without warning.

This method returns an undefined value.



691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
# File 'formula_auditor.rb', line 691

def audit_wayback_url
  return unless @core_tap
  return if formula.deprecated? || formula.disabled?

  regex = %r{^https?://web\.archive\.org}
  problem_prefix = "Formula with a Internet Archive Wayback Machine"

  if formula.stable && regex.match?(T.must(formula.stable).url)
    problem "#{problem_prefix} `url` should be deprecated with `:repo_removed`"
  end

  if regex.match?(formula.homepage)
    problem "#{problem_prefix} `homepage` should find an alternative `homepage` or be deprecated."
  end

  return unless formula.head

  return unless regex.match?(T.must(formula.head).url)

  problem "Remove Internet Archive Wayback Machine `head` URL"
end

#get_repo_data(regex) ⇒ Array<(String, String)>?

This method is part of a private API. This method may only be used in the Homebrew/brew repository. Third parties should avoid using this method if possible, as it may be removed or changed without warning.

Parameters:

  • regex (Regexp)

Returns:



802
803
804
805
806
807
808
809
810
811
812
813
814
# File 'formula_auditor.rb', line 802

def get_repo_data(regex)
  return unless @core_tap
  return unless @online

  _, user, repo = *regex.match(T.must(formula.stable).url) if formula.stable
  _, user, repo = *regex.match(formula.homepage) unless user
  _, user, repo = *regex.match(T.must(formula.head).url) if !user && formula.head
  return if !user || !repo

  repo.delete_suffix!(".git")

  [user, repo]
end

#problem_if_output(output) ⇒ void

This method is part of a private API. This method may only be used in the Homebrew/brew repository. Third parties should avoid using this method if possible, as it may be removed or changed without warning.

This method returns an undefined value.

Parameters:



1181
1182
1183
# File 'formula_auditor.rb', line 1181

def problem_if_output(output)
  problem(output) if output
end